Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: use DialContext #7227

Merged
merged 2 commits into from
Jan 25, 2017
Merged

clientv3: use DialContext #7227

merged 2 commits into from
Jan 25, 2017

Conversation

heyitsanthony
Copy link
Contributor

Fixes #7216

@xiang90
Copy link
Contributor

xiang90 commented Jan 24, 2017

Can we add a test for this?

xiang90
xiang90 reviewed Jan 25, 2017
View reviewed changes
clientv3/client_test.go

donec := make(chan struct{})
go func() {
close(donec)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should close(donec) after we call c.Close() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops, was getting the leak even without this...

@xiang90
Copy link
Contributor

xiang90 commented Jan 25, 2017

lgtm

@heyitsanthony heyitsanthony merged commit 094be29 into etcd-io:master Jan 25, 2017
@heyitsanthony heyitsanthony deleted the clientv3-dial-ctx branch January 25, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiang90 xiang90 xiang90 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyitsanthony @xiang90 @gyuho