Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: respect dial timeout in auth #7639

Merged
merged 2 commits into from
Apr 3, 2017
Merged

clientv3: respect dial timeout in auth #7639

merged 2 commits into from
Apr 3, 2017

Conversation

heyitsanthony
Copy link
Contributor

Fixes #7627

mitake
mitake approved these changes Apr 1, 2017
View reviewed changes
Copy link
Contributor

@mitake mitake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! LGTM

@mitake
Copy link
Contributor

mitake commented Apr 1, 2017

The failed test doesn't seem to be related to this change. I think this PR can be merged.

@heyitsanthony heyitsanthony merged commit f13bea0 into etcd-io:master Apr 3, 2017
@heyitsanthony heyitsanthony deleted the fix-userflag-timeout branch April 3, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitake mitake mitake approved these changes

Assignees
No one assigned
Labels
area/clientv3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyitsanthony @mitake @gyuho