auth: protect simpleToken with single mutex and check if enabled #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2017 13:17
etcd was crashing since auth was assuming a token implies auth is enabled.
Dual locking doesn't really give a convincing performance improvement and the lock ordering makes it impossible to safely check if the TTL keeper is enabled or not. Fixes etcd-io#7722
heyitsanthony
force-pushed
the
fix-auth-token-crash
branch
from
b5dcab8
to
18bccb4
Compare
|
An alternative to this is totally getting rid of the AuthEnable/AuthDisable anti-pattern from the AuthStore interface and have etcdserver dynamically add/remove Auth layer, which would entirely eliminate this class of bugs. |
|
LGTM. I will backport this with another patch release (probably on next Monday). |
gyuho
approved these changes
Apr 12, 2017
|
lgtm, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual locking doesn't really give a convincing performance improvement and
the lock ordering makes it impossible to safely check if the TTL keeper
is enabled or not.
/cc @raoofm @mitake
Fixes #7722