Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctlv3: keep lease as integer in fields printer #7775

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

heyitsanthony
Copy link
Contributor

Output was giving %!d(string=) instead of the expected lease ID
value.

Output was giving %!d(string=) instead of the expected lease ID
value.
@xiang90
Copy link
Contributor

xiang90 commented Apr 19, 2017

lgtm

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d3456b5). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7775   +/-   ##
=========================================
  Coverage          ?   75.79%           
=========================================
  Files             ?      331           
  Lines             ?    26091           
  Branches          ?        0           
=========================================
  Hits              ?    19775           
  Misses            ?     4881           
  Partials          ?     1435
Impacted Files Coverage Δ
etcdctl/ctlv3/command/printer_fields.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3456b5...fcd4871. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@heyitsanthony heyitsanthony merged commit 04fc57a into etcd-io:master Apr 19, 2017
@heyitsanthony heyitsanthony deleted the fix-lease-print branch April 19, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants