-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transport: use reverse lookup to match wildcard DNS SAN #8281
Conversation
if err != nil { | ||
errStr = " (" + err.Error() + ")" | ||
} | ||
return fmt.Errorf("tls: %q does not match any of DNSNames %q"+errStr, h, cert.DNSNames) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%q "+errStr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already gets the space from " ("
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks
Codecov Report
@@ Coverage Diff @@
## master #8281 +/- ##
==========================================
- Coverage 76.42% 76.21% -0.22%
==========================================
Files 346 346
Lines 27055 27079 +24
==========================================
- Hits 20676 20637 -39
- Misses 4901 4963 +62
- Partials 1478 1479 +1
Continue to review full report at Codecov.
|
This didn't work as approved; PTR records will return a trailing '.' that has to be stripped off. I've also added wildcard certs / a container for testing DNS. /cc @gyuho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks!
Can we have a 3.2.5 release? Waiting on this PR to re-enable peer authentication on my clusters. |
We will release this Wednesday or Friday. |
Fixes #8268