clientv3: put at most once #8335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Think this grpc/grpc-go#1369 has changed the behavior? On This is the commit with all diffs be794d5?diff=unified#diff-e3c9e37b41869259a878bdb08e61af6cL903. |
added 4 commits
August 1, 2017 10:31
Was retrying when it shouldn't, causing multiple puts
Switching endpoints on the same client was triggering balancer reconnect errors that should be tested in clientv3/integration.
Still gets transport closing errors, but no unavailable endpoint errors.
heyitsanthony
force-pushed
the
test-put-atmostonce
branch
from
c4e830e
to
fdba9e5
Compare
|
Failing on #6934; merging |
HardySimpson
reviewed
Aug 2, 2017
clientv3/retry.go
Outdated
| return err | ||
| }) | ||
| return resp, err | ||
| return rkv.KVClient.Put(ctx, in, opts...) |
There was a problem hiding this comment.
Good, if grpc return the error like remote network not availabe, I think we should still do retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to get errors out of put in 1.4 but the upgrade to 1.5 grpc seems to have changed error handling; haven't investigated fully. Removed the retry and added a test for at-most-once semantics during disconnects.
/cc @HardySimpson