Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: upgrade grpc/grpc-go to v1.7.4 #8972

Merged
merged 1 commit into from
Dec 5, 2017
Merged

vendor: upgrade grpc/grpc-go to v1.7.4 #8972

merged 1 commit into from
Dec 5, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Dec 4, 2017

To include upstream fix grpc/grpc-go#1687.
Already backported to release-3.2, planning v3.2.11 sometime this week.

Should fix #8904.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho requested review from jpbetz and xiang90 December 4, 2017 22:28
@xiang90
Copy link
Contributor

xiang90 commented Dec 4, 2017

lgtm

@gyuho
Copy link
Contributor Author

gyuho commented Dec 4, 2017

Will merge after all CIs pass (waiting for some others PRs to be merged, and will rebase).

Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit 287c23c into etcd-io:master Dec 5, 2017
@gyuho gyuho deleted the grpc branch December 5, 2017 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

gRPC v1.7.3 transport "panic: send on closed channel" on *serverHandlerTransport
3 participants