functional tests: re-purpose aws.sh for generating AMIs #2736
Conversation
iaguis
force-pushed
the
iaguis/jenkins-amis
branch
3 times, most recently
from
679f0f9
to
593a28f
Compare
|
Not sure about the status of this, but not ready for 1.8.0. Assigned to @alban as part of the bigger Jenkins task. |
|
@alban PTAL |
|
| sleep 30 | ||
| done | ||
|
|
||
| AMI_ID=$(aws --region $REGION ec2 create-image --instance-id $INSTANCE_ID --name $DISTRO-rkt-test --output text) |
There was a problem hiding this comment.
Don't you need to stop the instance before taking the snapshot?
There was a problem hiding this comment.
Creating the image will stop the instance.
|
ping |
| @@ -125,50 +87,49 @@ INSTANCE_ID=$(aws ec2 run-instances \ | |||
| ) | |||
| echo INSTANCE_ID=$INSTANCE_ID | |||
|
|
|||
| aws ec2 create-tags --resources $INSTANCE_ID \ | |||
There was a problem hiding this comment.
could we still add some tags? So if the script is interrupted, we know what were the EC2 instances created for.
|
Moving to milestone v1.11.0, when @iaguis will have some time to continue this. |
iaguis
force-pushed
the
iaguis/jenkins-amis
branch
from
593a28f
to
545dba6
Compare
iaguis
force-pushed
the
iaguis/jenkins-amis
branch
from
545dba6
to
c81c72c
Compare
iaguis
changed the title
|
Updated. Wrote some documentation. |
| chmod +x /var/tmp/rkt-test.sh | ||
|
|
||
| systemd-run --unit=rkt-test /var/tmp/rkt-test.sh | ||
| sudo sed -i 's/ requiretty$/ !requiretty/g' /etc/sudoers |
There was a problem hiding this comment.
Does this "sudo" work?
Is it still executed by --user-data file://$CLOUDINIT? Then doesn't it already run as root?
Otherwise, the patch on /etc/sudoers is to fix sudo, so not sure you can use sudo for this command if it does not work...
There was a problem hiding this comment.
TBH I haven't tried centos...
There was a problem hiding this comment.
You're right. I can remove the sudo from everywhere. Thanks!
iaguis
force-pushed
the
iaguis/jenkins-amis
branch
from
c81c72c
to
8f1d272
Compare
This changes the aws.sh script to generate AMIs with the rkt dependencies installed so they can be used in Jenkins.
iaguis
force-pushed
the
iaguis/jenkins-amis
branch
from
8f1d272
to
2ecf315
Compare
|
Updated with a debian-testing cloudinit (as per #2951). |
|
LGTM |
|
Fixes #2951 |
|
Functional tests don't make sense here. Merging. |
This changes the aws.sh script to generate AMIs with the rkt
dependencies installed so they can be used in Jenkins.
cc @albanc