rkt/stop: implement --uuid-file #2902
Conversation
|
test? |
| podUUID, err := resolveUUID(uuid) | ||
| ret := 0 | ||
| switch { | ||
| case len(args) == 0 && flagUUIDFile != "": |
There was a problem hiding this comment.
So it is either UUID or --uuid-file=FILE? Why not both? In this case, the usage in cobra should be updated.
Use: "stop --uuid-file=FILE | UUID ...",
There was a problem hiding this comment.
Yeah, I noticed that, we should change it in rkt rm too
We allow either `UUID` or `--uuid-file`, not both. Reflect that on the help string.
So the user can use the value saved on rkt run with --uuid-file-save.
It's already included by the log package.
|
Updated. |
|
As you are touching it, I think it makes sense to also align |
|
Since one is reading the file and the other is saving it I'm not sure they should have the same name... cc @robszumski |
|
@iaguis I see my suggestion was not un-controversial as I was expecting, so let's wait for a tie-breaking input from @robszumski on it. In the meanwhile, we can decouple this discussion from landing this. Current PR looks fine as-is, flag renaming (if accepted) can be done separately. |
So the user can use the value saved on rkt run with --uuid-file-save.
Fixes #2892