This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
functional tests: add some more volume/mount tests #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,11 +31,19 @@ import ( | |||
| "github.com/appc/spec/schema/types" | |||
| ) | |||
|
|
|||
| // Some of these tests persistently modify files; subsequent test rows | |||
There was a problem hiding this comment.
Is this necessary? Interdependent tests are unfortunate
There was a problem hiding this comment.
I didn't do it! Just leaving a note for the next committer.
|
LGTM |
squeed
force-pushed
the
testvolumes-enhancement
branch
from
0945547
to
de0d6c3
Compare
|
The Semaphore test failure is spurious. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2329