store,rkt: fix fd leaks #2906

iaguis · 2016-07-11T13:36:23Z

Close db lock on store close. If we don't do it, there's a fd leak everytime we open a new Store, even
if it was closed.

Also, close overlay-prepared when checking if a pod uses overlay.

Fixes #2899

We weren't closing the file when we checked if the pod used overlay.

If we don't do it, there's a fd leak everytime we open a new Store, even if it was closed.

sgotti · 2016-07-11T13:40:46Z

@iaguis for a strange coincidence the store part is automatically fixed with #2897 😄

iaguis · 2016-07-11T13:41:54Z

👍 for deleting code :)

sgotti · 2016-07-11T13:52:22Z

This LGTM. Feel free to merge this since probably #2897 needs more review.

iaguis · 2016-07-11T14:10:55Z

OK, we'll merge this for now and we'll have a look at your PR afterwards.

iaguis · 2016-07-11T14:11:02Z

On green, of course :)

iaguis added 2 commits July 11, 2016 15:35

rkt: close leaking overlay-prepared fd

639a17c

We weren't closing the file when we checked if the pod used overlay.

store: close db lock on store close

52a3c05

If we don't do it, there's a fd leak everytime we open a new Store, even if it was closed.

iaguis added kind/bug component/store area/usability needs/review labels Jul 11, 2016

iaguis added reviewed/lgtm and removed needs/review labels Jul 11, 2016

iaguis merged commit b82b07b into rkt:master Jul 11, 2016

Provide feedback