build: add support for more architectures at configure time #2907
Conversation
| [x86_64], [RKT_ACI_ARCH=amd64; GOARCH=amd64;], | ||
| [AC_MSG_ERROR([*** unsupported host architecture specified: ${host_cpu}])]) | ||
| [aarch64], [RKT_ACI_ARCH=aarch64; GOARCH=arm64;], | ||
| [armv7l], [RKT_ACI_ARCH=unsupported; GOARCH=arm; GOARM=7;], |
There was a problem hiding this comment.
I see what's the logic behind this (finding supported stage1 arch) but I find the use of RKT_ACI_ARCH for it quite confusing. I think this variable should instead mirror the labels at https://github.com/appc/spec/blob/master/schema/types/labels.go#L24 and the unsupported check should be self-contained in the AS_VAR_IF check later on.
lucab
changed the title
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Geoff Levand <geoff@infradead.org>
Used for 32 bit ARM builds. Signed-off-by: Geoff Levand <geoff@infradead.org>
|
Rebased to latest, split setting of variables and checking of support. |
|
LGTM now. I see we are still dropping ppc64 due to the lack of corresponding appc labels. I've submitted appc/spec#639 for that, and we may consider re-adding ppc64 after the next appc/spec bump. /cc @onlyjob as this may require a removal from Debian testing for ppc64el until that is sorted out, to let new versions properly migrate in the meanwhile. |
|
@lucab yeah, I think it worthwhile to prepare for powerpc support. There was some work towards a ppc64le port of CoreOS. |
Fixes #2898