This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Doc: Update rktnetes docs. #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have any instructions for coreos-kubernetes? @aaronlevy @pbx0 |
|
|
||
| [getting started with rkt guide]: http://kubernetes.io/docs/getting-started-guides/rkt/ | ||
| More information on how to launch and debug the rktnetes cluster in different environment can be found in the [official user guide](http://kubernetes.io/docs/getting-started-guides/rkt/). |
There was a problem hiding this comment.
nit: "in different environments" or "a different environment"
|
|
||
| The [getting started with rkt guide][] in the upstream Kubernetes documentation provides more detailed information about how to launch a kubernetes cluster with rkt, how to debug it, and more. | ||
| - `--container-runtime=rkt` sets the node’s container runtime to rkt. |
There was a problem hiding this comment.
I think you've got smart quotes or something - ’ -> '
There was a problem hiding this comment.
What do you mean? highlight vs "highlight"
There was a problem hiding this comment.
oh, you mean the node’s vs node's, I see
|
LGTM after quote fix |
|
Updated |
| For the latest information on the progress of the integration, check out [this Google doc][rkt-k8s-checklist] which tracks the detailed status of implemented functionality. | ||
|
|
||
| [rkt-k8s-checklist]: https://docs.google.com/document/d/1dYxInIUDTm4HEArQ9Hom_1NhYw22WrXWdglnaLjtQsI/edit | ||
| Integration of rkt as a container runtime for Kubernetes is officially supported and [announced in 1.3 release](http://blog.kubernetes.io/2016/07/rktnetes-brings-rkt-container-engine-to-Kubernetes.html). |
There was a problem hiding this comment.
"Integration of rkt as a container runtime was officially announced in the Kubernetes 1.3 release."
|
Addressed @joshix 's comments. |
|
LGTM (would like to update to reference-style markdown links in next iteration) |
|
@joshix Thank you, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tmrts @euank @joshix