-
Notifications
You must be signed in to change notification settings - Fork 884
Conversation
Can one of the admins verify this patch? |
ok to test |
This looks OK for now, but the value of interpBin is really dependent on the source files used to create the stage1 image, and in general could be different for the different stage1 flavors. I'm thinking now that having these init_linux files could be problematic, and that maybe the solution is to have interpBin set by the build at configure or make. |
The Other than that, I agree with @glevand remark that |
I added the Should I then just remove the second commit, and fix it in another PR? |
Yes, please. It doesn't make much sense to keep multiplying files for architectures that don't even need it. amd64 & arm64 should be set via specific built-time constants, passing a default placeholder for the rest. |
On x86 machines, GOARCH should be '386', not 'i386'. Signed-off-by: Thomas Hipp <thipp@suse.de>
I have removed the 2nd commit. |
LGTM |
This PR fixes a minor issue which leads to x86 builds failing.
The GOARCH environment variable should be
386
instead ofi386
.