This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
functional test: check PATH variable for trailer \n character
#2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s/path/patch/ for some instances of path in the commit message :) |
| @@ -83,6 +84,7 @@ var ( | |||
| func init() { | |||
| globalFlagset.BoolVar(&globalFlags.ReadStdin, "read-stdin", false, "Read a line from stdin") | |||
| globalFlagset.BoolVar(&globalFlags.CheckTty, "check-tty", false, "Check if stdin is a terminal") | |||
| globalFlagset.BoolVar(&globalFlags.CheckPath, "check-path", false, "Check if environament variable PATH do not terminate with \\n\\0") | |||
There was a problem hiding this comment.
s/environament/environment
"does not"
alepuccetti
force-pushed
the
alessandro/test-newline-env
branch
from
a7fa1df
to
4034a3e
Compare
| if len(v) == 0 { | ||
| continue | ||
| } | ||
| if strings.Contains(string(v), "PATH=") { |
alepuccetti
force-pushed
the
alessandro/test-newline-env
branch
from
4034a3e
to
97f981f
Compare
|
Patch updated, not sure if error is related |
|
It seems to be #2943 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the test for #2901,
it tests that
$PATHdoes not end with\n\0but with\0.This fixes #2905
Related to #2893
This patch also introduces the
--check-pathflag ininspect.goto carry out the test.