Sg2265/carriage-login #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 652bba2.
- all CSS located in one file - decreased font-size - fixed file formatting
|
[diff-counting] Significant lines: 236. |
CollinWoo
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Great work on this feature Stuti! The footer looks good for the most part but the images don't seem to show up on my end. I was able to fix this by importing the images explicitly at the top of the file (e.g. import group525 from './Group525.png') and then adding this import as the source of the image (e.g. <img src={group525}></img>) instead of hard-coding the path directly. Otherwise, everything looks great!
… progress (not finished
|
Your preview environment cornell-dti-carriage-web-pr-446 has been deployed. Preview environment endpoints are available at: |
|
Your preview environment cornell-dti-carriage-web-pr-446 has been deployed. Preview environment endpoints are available at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Started modifying carriage-login based on new Figma design