Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar does not handle courses that have ended correctly #448

Closed
abcdefguan opened this issue Dec 16, 2020 · 2 comments · Fixed by #445
Closed

Top bar does not handle courses that have ended correctly #448

abcdefguan opened this issue Dec 16, 2020 · 2 comments · Fixed by #445

Comments

@abcdefguan
Copy link
Contributor

You can see from this image that the top bar lets users choose between {CS 3110, Test, Info 4998}
Screenshot from 2020-12-16 09-13-17
However, if you look at edit courses, only Test and Info 4998 appear
Screenshot from 2020-12-16 09-14-02
It turns out that CS 3110 expired on 18 Oct and should no longer be selectable
Screenshot from 2020-12-16 09-14-54
When clicking on CS 3110 from the top bar options, nothing happens and you don't actually go to CS 3110's office hours.

Current Behaviour: Expired courses (CS 3110) appear on top bar and are selectable but selection results in no progression.
Correct Behaviour: Expired courses (CS 3110) should not appear on top bar

@abcdefguan abcdefguan linked a pull request Dec 16, 2020 that will close this issue
2 tasks
@ngwattcos
Copy link
Member

ngwattcos commented Dec 17, 2020

@abcdefguan Have not confirmed but I suspect that the start date of January 20 is the real reason it is not showing up.

EDIT: For some (older) users, old classes show up when not in editing node:
image

@abcdefguan
Copy link
Contributor Author

Why would that be the case? When do you cut off the start dates (how many months)?
You should consolidate the former classes logic with the logic used to display tabs on the top bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants