-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add VOLUME_NEW_IMAGE event and Add jumpToSlice and default VOI for volume viewport #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Some changes required mostly about unsubscribing to events, and cleaning up state.
packages/core/src/RenderingEngine/helpers/volumeNewImageEventDispatcher.ts
Outdated
Show resolved
Hide resolved
packages/core/src/RenderingEngine/helpers/volumeNewImageEventDispatcher.ts
Show resolved
Hide resolved
packages/core/src/utilities/getImageSliceDataForVolumeViewport.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One consideration on the element disabled events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thing there is still an event issue, plus some other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think there is a dangling event listener issue here, more in line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly there, comments in line.
Fix:
Refactor
@cornerstonejs/core
camera-related utility functions out of their incorrect location in the@cornertsontejs/tools
Add
imageIndex
of the image that has rendered in the volume viewport (any camera view)jumpToSlice
to jump to a slice in thevolumeViewport