feat(dicomImageLoader types): Add types to the dicom image loader #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
changed the title
packages/dicomImageLoader/examples/customWebWorkerTask/index.html
Outdated
Show resolved
Hide resolved
packages/dicomImageLoader/src/imageLoader/wadors/metaData/getNumberValue.ts
Outdated
Show resolved
Hide resolved
packages/dicomImageLoader/src/imageLoader/wadors/metaData/getValue.ts
Outdated
Show resolved
Hide resolved
packages/dicomImageLoader/src/imageLoader/wadors/metaData/metaDataProvider.ts
Outdated
Show resolved
Hide resolved
packages/dicomImageLoader/src/imageLoader/wadouri/dataset-from-partial-content.ts
Show resolved
Hide resolved
Closed
packages/dicomImageLoader/src/shared/decoders/decodeJPEG2000.ts
Outdated
Show resolved
Hide resolved
| | 'sopCommonModule' | ||
| | string; | ||
|
|
||
| export interface DicomDateObject { |
There was a problem hiding this comment.
If this is getting retrieved/parsed, we should always get it as a combined date/time object. Splitting it up causes all sorts of issues. If we are going to not parse, then just leaving the value as a string is preferred.
There was a problem hiding this comment.
It is referenced in the MetadataGeneralSeriesModule what should I do?
|
There seem to be a lot of weird stuff happening for the esm build. The esm builds fine, but using the build inside OHIF (branch here https://github.com/OHIF/Viewers/tree/feat/dicomImageLoader) has the following error seems like the export defaults are messed up? |
Co-authored-by: James Manners <james@binary.com.au>
* Improve WARORS types as per PR comments * [dicom-image-loader] add types for wasm codec modules * [dicom-image-loader] relocate WASM types --------- Co-authored-by: James Manners <james@binary.com.au>
sedghi
force-pushed
the
feat/dicom-image-loader
branch
from
d4585e5
to
1e6b315
Compare
wayfarer3130
approved these changes
Mar 1, 2023
|
This will get updated in another PR to use the new dicomImageloader, this PR is just for adding types |
|
I just tried to use cornestoneDicomImageLoader in my project, but there are no type files available. The compiler does not find them, and I also cant find them in the node_modules folder. I see here, that in the last commit 0192389129 everything was reverted to the old cornerstoneWADOImageLoader without TS support. |
I am having a similar issue. Trying to use the cornerstone suite of tools in an angular application to load + view local DICOM files. I was able to install the core and tools packages and they seem to be working. But my IDE is giving an error when trying to import dicom-image-loader. Does this package work with typescript?
|
|
No that one is not typescript yet |
|
Ok thanks for the info. Perhaps the documentation should be updated then? |
|
Yes i guess, would be great if you add a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shout-out to @jmannau and his team at Pliny for their awesome work on the TypeScript addition to the cornerstoneWADOImageLoader. They were a crucial part of this PR for adding types to this project and their hard work made my job so much easier, which was mostly copy pasting.
Todo
Seems like the ESM build does not work properly with the codecs "exports".
As per my investigation, the
moduleResolutionin the tsConfig is "node" which is basically "node10" and not newer node versions that supports "export".See these references