Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/camera events #83

Merged
merged 5 commits into from
Apr 22, 2022
Merged

Fix/camera events #83

merged 5 commits into from
Apr 22, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 22, 2022 •
edited
Loading

  • change the camera interface to include flipHorizontal and flipVertical
  • move the rotation to the camera modified event detail
  • remove the flipHorizontal and flipVertical properties from the setProperties and add it to the setCamera
  • fix the CPU rendering for the non-scaled PT images
  • trigger camera modified for the setRotation and setFlip methods
  • fix the tools to use the constructor toolName to avoid problem with inherited tools
  • fix the windowLevel tool to work for non-scaled PT images

@sedghi sedghi requested a review from JamesAPetts April 22, 2022 00:44
JamesAPetts
JamesAPetts approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sedghi sedghi merged commit 82115ec into main Apr 22, 2022
@swederik swederik deleted the fix/camera-events branch July 8, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesAPetts JamesAPetts JamesAPetts approved these changes

@swederik swederik swederik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sedghi @swederik @JamesAPetts