Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs appear when using setColorForSegmentIndex #469

Closed
MYWpro opened this issue Mar 9, 2023 · 7 comments · Fixed by #535
Closed

Bugs appear when using setColorForSegmentIndex #469

MYWpro opened this issue Mar 9, 2023 · 7 comments · Fixed by #535

Comments

@MYWpro
Copy link

MYWpro commented Mar 9, 2023

https://user-images.githubusercontent.com/91541200/223910233-98ae7ee6-bc8f-4d4b-a95c-04868b1b4ff3.mp4
I want to change the color of the segment. I try to use a button to trigger setColorForSegmentIndex, but he has a bug in the video. Although the icon color of the brush has changed, the brush still draws the original color, and the color of the previously drawn segment has not changed. Which of my steps is wrong? Or what other ways to meet this demand
image

@sedghi
Copy link
Member

sedghi commented Mar 10, 2023

I can't see the video just FYI

@MYWpro
Copy link
Author

MYWpro commented Mar 11, 2023

I can't see the video just FYI

20230311172857.mp4

@MYWpro
Copy link
Author

MYWpro commented Mar 11, 2023

I can't see the video just FYI

I don't know what went wrong. It seems that you can only watch it after downloading it

@sedghi
Copy link
Member

sedghi commented Mar 13, 2023

I see, let me have a look

@alex644715
Copy link

alex644715 commented Mar 21, 2023

any update? I can upload some image to show this status

image

The color of brush was changed after run code above.

截屏2023-03-21 22 53 56

However the color of this drawed sphere segment is still original color
image

even I change the color in SphereScissorsTools.js from @cornerstonejs, is same result.

image

@MYWpro
Copy link
Author

MYWpro commented Mar 30, 2023

@alex644715 Have you solved this problem?

@sedghi
Copy link
Member

sedghi commented Mar 30, 2023

I pushed a fix and will merge after it passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants