fix(PET vs PT): Change all to PT for consistency #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jbocce
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
The changes thus far seem fine.
It looks like the API check is failing due to the rename.
Also, I did a search of pet and found many references (mostly in comments and docs). Do we care about these? There were also a few in uids.ts. Not sure how important those are.
|
@jbocce The rest are documentations, there shouldn't be any property of a class or variable called PET, I think I got them all, no? |
I suppose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This Pull Request addresses an issue of inconsistency in the naming convention used in the codebase. The problem was between using "PET" and "PT" terms. To ensure consistency across the project, all instances of "PET" have been changed to "PT"1.
Also isPrescaled was wrong and it should be isPreScaled
Changes & Results
Change PET -> PT
and isPrescaled -> isPreScaled
Testing
OHIF MPR for PT does not work because of this check but the volume has isPrescaled :(
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment