Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type annotations #373

Closed
raybellwaves opened this issue Jul 6, 2021 · 1 comment · Fixed by #507
Closed

add type annotations #373

raybellwaves opened this issue Jul 6, 2021 · 1 comment · Fixed by #507
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@raybellwaves
Copy link
Contributor

See geopandas/geopandas#1974

Would be good to add default parameters in the doc strings as well e.g. https://github.com/corteva/rioxarray/blob/master/rioxarray/rioxarray.py#L683 (default inplace arg is True).
@raybellwaves raybellwaves added the proposal Idea for a new feature. label Jul 6, 2021
@snowman2 snowman2 added the enhancement New feature or request label Jul 6, 2021
@snowman2
Copy link
Member

snowman2 commented Jul 6, 2021

PRs with more type annotations are definitely welcome 👍

@snowman2 snowman2 removed the proposal Idea for a new feature. label Jul 6, 2021
@snowman2 snowman2 added the help wanted Extra attention is needed label Oct 6, 2021
@snowman2 snowman2 mentioned this issue Apr 12, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TYPE: Add more type hints corteva/rioxarray
2 participants
@snowman2 @raybellwaves