Add save as copy to module and chart resources #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fajfa
requested changes
Oct 6, 2023
Fajfa
requested changes
Oct 16, 2023
| @@ -527,7 +528,9 @@ export default { | |||
| const { namespaceID } = this.namespace | |||
|
|
|||
| if (chartID === NoID) { | |||
| let c = new compose.Chart({ namespaceID: this.namespace.namespaceID }) | |||
| const chartClone = this.$attrs.chart || {} | |||
There was a problem hiding this comment.
I don't think you need this anymore
| { fields: [new compose.ModuleFieldString({ fieldID: NoID, name: this.$t('general.placeholder.sample') })] }, | ||
| this.namespace, | ||
| ) | ||
| if (this.$attrs.module) { |
There was a problem hiding this comment.
Dont think you need this anymore
| chart.name = `${this.chart.name} (copy)` | ||
| chart.handle = `${this.chart.handle}_copy` | ||
|
|
||
| const resourceTranslationLanguage = this.currentLanguage |
There was a problem hiding this comment.
Instead of copying the code, make handleSave accept a chart, and work with that. Then just call handleSave(chart) inside handleClone()
| module.name = `${this.module.name} (copy)` | ||
| module.handle = `${this.module.handle}_copy` | ||
|
|
||
| const resourceTranslationLanguage = this.currentLanguage |
There was a problem hiding this comment.
Same here, instead of copying the code just call handleSave(module) and make it accept a module.
Also make sure it doesn't check for isEdit, but instead it check if ID is equal NoID, like chart does.
Fajfa
requested changes
Oct 17, 2023
| @@ -616,16 +615,18 @@ export default { | |||
| this.processing = false | |||
| }, | |||
|
|
|||
| handleSave ({ closeOnSuccess = false } = {}) { | |||
| handleSave ({ closeOnSuccess = false, chart } = {}) { | |||
There was a problem hiding this comment.
Why not just chart = this.chart? Saves you trouble of renaming everything
| @@ -766,19 +762,21 @@ export default { | |||
| this.module.config = { ...this.module.config, ...changes } | |||
| }, | |||
|
|
|||
| handleSave ({ closeOnSuccess = false } = {}) { | |||
| handleSave ({ closeOnSuccess = false, module } = {}) { | |||
kelanik8
force-pushed
the
2023.3.x-feature-save-as-copy-compose
branch
from
92b5125
to
caad998
Compare
Fajfa
approved these changes
Oct 17, 2023
kelanik8
force-pushed
the
2023.3.x-feature-save-as-copy-compose
branch
from
caad998
to
9b07c10
Compare
|
Two questions, the rest is okay:
|
Fajfa
approved these changes
Oct 23, 2023
kelanik8
force-pushed
the
2023.3.x-feature-save-as-copy-compose
branch
from
595c177
to
55fed4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR