Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated #239

Closed
osallou opened this issue Mar 20, 2019 · 3 comments
Closed

importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated #239

osallou opened this issue Mar 20, 2019 · 3 comments

Comments

@osallou
Copy link

osallou commented Mar 20, 2019

Hi,
I get this warning relative to deprecation and future python support removal (got it in many other libs too...)
I am using version 3.0.7

.../venv/lib64/python3.7/site-packages/flask_cors/core.py:322: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

and isinstance(obj, collections.Iterable)):
@jdevera
Copy link

jdevera commented Jun 1, 2019

six should cover this but alas the PR is stuck: benjaminp/six#241

@jdevera
Copy link

jdevera commented Jun 1, 2019

Related: #243

@corydolphin
Copy link
Owner

Thank you! Fix is merged as #243 and will be deployed shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdevera @corydolphin @osallou