Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio waveform normalization inconsistency #34

Open
ejhumphrey opened this issue Jun 14, 2019 · 2 comments
Open

audio waveform normalization inconsistency #34

ejhumphrey opened this issue Jun 14, 2019 · 2 comments

Comments

@ejhumphrey
Copy link
Contributor

I've been checking our math given fresh eyes from the passage of time, and it seems like we (I) have been inconsistent as to when the audio signal gets normalized (scaled within [-1, 1]). In the initial work (the InstrumentDNN), all audio was scaled prior to waveform_to_examples. Now it looks like we're only doing that for the user if they come in through soundfile_to_examples... but not the other ones.

I'd propose the following corrective action:

  • add a normalize=True default kwarg to waveform_to_examples [src]
  • plumb this kwarg through wavfile_to.. and soundfile_to...
@ejhumphrey
Copy link
Contributor Author

thoughts @bmcfee ?

@bmcfee
Copy link
Collaborator

bmcfee commented Jun 19, 2019

i see your point -- since normalization is (should be) idempotent, i think it makes more sense to do it as close to processing as possible (ie inside waveform_to_examples) as you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants