You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been checking our math given fresh eyes from the passage of time, and it seems like we (I) have been inconsistent as to when the audio signal gets normalized (scaled within [-1, 1]). In the initial work (the InstrumentDNN), all audio was scaled prior to waveform_to_examples. Now it looks like we're only doing that for the user if they come in through soundfile_to_examples... but not the other ones.
I'd propose the following corrective action:
add a normalize=True default kwarg to waveform_to_examples [src]
plumb this kwarg through wavfile_to.. and soundfile_to...
The text was updated successfully, but these errors were encountered:
i see your point -- since normalization is (should be) idempotent, i think it makes more sense to do it as close to processing as possible (ie inside waveform_to_examples) as you suggest.
I've been checking our math given fresh eyes from the passage of time, and it seems like we (I) have been inconsistent as to when the audio signal gets normalized (scaled within [-1, 1]). In the initial work (the InstrumentDNN), all audio was scaled prior to
waveform_to_examples
. Now it looks like we're only doing that for the user if they come in through soundfile_to_examples... but not the other ones.I'd propose the following corrective action:
normalize=True
default kwarg towaveform_to_examples
[src]wavfile_to..
andsoundfile_to...
The text was updated successfully, but these errors were encountered: