Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename github.com/gogo/protobuf fork to github.com/cosmos/gogoproto #10925

Closed
aaronc opened this issue Jan 10, 2022 · 3 comments · Fixed by #13070
Closed

Rename github.com/gogo/protobuf fork to github.com/cosmos/gogoproto #10925

aaronc opened this issue Jan 10, 2022 · 3 comments · Fixed by #13070
Assignees
@julienrbrt

Comments

@aaronc
Copy link
Member

aaronc commented Jan 10, 2022

Needing the replace directive in go.mod is confusing and a barrier to entry. We should just go to the fork and rename everything. It will be painful, but we'll only need to do it once and it will be done for posterity's sake. It may be a while before we can fully deprecate gogo because we want to allow the pulsar migration to be incremental, especially for 3rd party modules.
@aaronc aaronc added this to the v0.46 milestone Jan 12, 2022
@tac0turtle
Copy link
Member

Can you list what needs to be forked and renamed? im guessing you are suggesting a fork of gogo and rename things in the compiled code?

@alexanderbez
Copy link
Contributor

https://github.com/cosmos/protobuf

You both have admin access along with regen having write access.

@tac0turtle tac0turtle mentioned this issue Mar 3, 2022
Closed
19 tasks
@aaronc aaronc changed the title Rename github.com/gogo/protobuf fork to github.com/regen-network/protobuf Rename github.com/gogo/protobuf fork to github.com/cosmos/protobuf Mar 3, 2022
@aaronc aaronc changed the title Rename github.com/gogo/protobuf fork to github.com/cosmos/protobuf Rename github.com/gogo/protobuf fork to github.com/cosmos/gogo-protobuf Mar 3, 2022
@aaronc aaronc changed the title Rename github.com/gogo/protobuf fork to github.com/cosmos/gogo-protobuf Rename github.com/gogo/protobuf fork to github.com/cosmos/gogoproto Mar 3, 2022
@amaury1093 amaury1093 mentioned this issue Mar 16, 2022
Closed
56 tasks
@robert-zaremba robert-zaremba self-assigned this Mar 18, 2022
@robert-zaremba robert-zaremba mentioned this issue Mar 18, 2022
Closed
19 tasks
@tac0turtle tac0turtle moved this from Todo to In Progress in Cosmos SDK: Framework WG Apr 11, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 12, 2022
@tac0turtle
Copy link
Member

We will push this from 0.46 to a later release due to a tight timeline

@tac0turtle tac0turtle removed the R:0.46 label May 12, 2022
@tac0turtle tac0turtle removed this from the v0.46 milestone May 12, 2022
@julienrbrt julienrbrt mentioned this issue Aug 18, 2022
Merged
19 tasks
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Aug 18, 2022
@julienrbrt julienrbrt mentioned this issue Aug 29, 2022
Merged
19 tasks
@ryanchristo ryanchristo mentioned this issue Aug 31, 2022
Open
4 tasks
@julienrbrt julienrbrt moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Sep 8, 2022
Repository owner moved this from In Progress to Done in Cosmos SDK: Framework WG Sep 8, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Sep 8, 2022
@colin-axner colin-axner mentioned this issue Nov 2, 2022
Closed
3 tasks
@nyetwurk nyetwurk mentioned this issue Nov 20, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Cosmos SDK: Framework WG
Status: Done
Milestone
No milestone
5 participants
@aaronc @robert-zaremba @alexanderbez @tac0turtle @julienrbrt