Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashing v2 (probably-not-final) #1117

Closed
4 of 6 tasks
cwgoes opened this issue Jun 1, 2018 · 4 comments
Closed
4 of 6 tasks

Slashing v2 (probably-not-final) #1117

cwgoes opened this issue Jun 1, 2018 · 4 comments
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jun 1, 2018

  • Evidence queue (kept for one unbonding period relative to discovery) for slashing on unbonding completion, spec updated accordingly Now using eager slashing
  • Automatically unbond validators on double-signing
  • SlashingKeeper common type in types to expose this functionality for staking
  • REST server handler for unrevoke transaction & signing info status queries
  • CLI documentation
  • Tagged slashing events for UIs

This should be final (for launch). Anything I missed @rigelrozanski? edit: overly optimistic

@cwgoes cwgoes self-assigned this Jun 1, 2018
@cwgoes cwgoes changed the title Slashing v2 Slashing v2 (final) Jun 1, 2018
@rigelrozanski
Copy link
Contributor

We need to update the spec as a part of this ideally - As per our discussion with @sunnya97 - we should now ONLY have eager slashing meaning that we no longer need to maintain the evidence queue. - > as a part of this we don't actually need a slashing keeper in types - because staking complete-unbond transaction no longer needs to perform the slashing

Lastly - let's either open up an issue of implement a "max rebonding/unbonding" slashes per block so if there is a lot to iterate through it happens over multiple blocks

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 22, 2018

Ref #1348

@cwgoes cwgoes changed the title Slashing v2 (final) Slashing v2 (semi-final) Jun 26, 2018
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 26, 2018

Ref #1378

@cwgoes cwgoes mentioned this issue Jun 27, 2018
6 tasks
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 28, 2018

Ref #1440

This is probably not final slashing at this point, but the next revision should come after a more clearly-defined security model.

@cwgoes cwgoes changed the title Slashing v2 (semi-final) Slashing v2 (probably-not-final) Jun 28, 2018
@cwgoes cwgoes reopened this Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants