Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed store/v2 -> store/v2alpha1 #11378

Closed
Tracked by #11096
aaronc opened this issue Mar 15, 2022 · 0 comments · Fixed by #11392
Closed
Tracked by #11096

Renamed store/v2 -> store/v2alpha1 #11378

aaronc opened this issue Mar 15, 2022 · 0 comments · Fixed by #11392
Assignees

Comments

@aaronc
Copy link
Member

aaronc commented Mar 15, 2022

store/v2 was not broken out into a standalone go module and we may want to do that at some point. Releasing it in the SDK as is will more or less prevent us for doing that because of the way the go module resolver works in terms of carving out new modules (see https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository). Thus would essentially force us to jump to store/v3.

Since store/v2 has not as far as we know gone into a stable release, we intend to rename it to store/v2alpha1 before 0.46 to all for a standalone store/v2 later, possibly with some API changes as well.

@aaronc aaronc added this to the v0.46 milestone Mar 15, 2022
@amaury1093 amaury1093 mentioned this issue Mar 16, 2022
56 tasks
@mergify mergify bot closed this as completed in #11392 Mar 16, 2022
@mergify mergify bot moved this to Done in COSMOS SDK: Store v2/ SMT Mar 16, 2022
mergify bot pushed a commit that referenced this issue Mar 16, 2022
## Description

Closes: #11378 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants