Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SimulationState accept sdk.Int as value for InitialStake. #11795

Closed
4 tasks
V-Staykov opened this issue Apr 27, 2022 · 2 comments · Fixed by #11855
Closed
4 tasks

Make SimulationState accept sdk.Int as value for InitialStake. #11795

V-Staykov opened this issue Apr 27, 2022 · 2 comments · Fixed by #11855

Comments

@V-Staykov
Copy link

Summary

Currently SimulationState accepts int64 as value for InitialStake. This leads to limit in the initial stake. It is later converted to sdk.Int anyways, so it would be better for it to accept sdk.Int and make it possible to set higher values.

Problem Definition

We've added a limit in the minimum self delegation in our fork, so we had to change all tests to use higher values for valdiator creations. This led to TestAppSimulationAfterImport and others like it failing. We needed to change the SimulationState to set higher InitialStakes.

Proposal

Refactor the sims to use sdk.int


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

ACK. Thanks for the issue @V-Staykov 🙌

@facundomedica
Copy link
Member

I'll pick this one up :) Using the new sdkmath "cosmossdk.io/math" instead of sdk "github.com/cosmos/cosmos-sdk/types" 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants