Rename EIP191 Sign Mode

[sunnya97]

#11533 introduced a new SignMode enum variant called simply EIP191. However, this name is not precise enough. EIP 191 simply refers to a method of encoding a string data to be signed.

However, the Sign Mode concept in Cosmos SDK also refers to how to encode a tx into a string in the first place.

For this reason, in the osmosis-labs version of this, we specifically call this "EIP191LegacyJSON" to signal that it is the EIP191 re-encoded version of the Amino JSON string.

In the future, we will probably want more EIP191 sign modes, such as an EIP191Textual which wraps SignModeTextual.

I think any new sign modes should have an associated ADR for them. For example, in the case of EIP191LegacyJSON, we would also need to standardize how to format the amino json (such as adding new lines and indents) before putting it through the EIP191 conversion.

For this reason, the current sign mode called EIP191 needs to be renamed to avoid confusion. If renaming it is not possible, then it should be deprecated and replaced with a properly named variant.

@AmauryM @fedekunze @alexanderbez

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[sunnya97]

@fedekunze what tx encoding are you using for this 191 sign mode? We should rename EIP191 sign mode to be properly named to be more specific and precise.

[alexanderbez]

Agreed. @fedekunze would you or anyone from your team be willing to make amendments to #11533?

[fedekunze]

I'm fine renaming it, I won't be able to look into it until EOW most likely so happy if someone can give me a hand here.

[amaury1093]

I don't think we can rename it though, since it would be a proto-breaking change. We can simply deprecate the existing enum option, and add new ones.

[sunnya97]

Enum names are proto-breaking?

[amaury1093]

Yes.

Changing field/enum names is also breaking for clients (e.g. CosmJS) when they generate code or use the proto JSON representation. We decided in adr-044 to simply just never allow renames.

[JulianToledano]

I can work on this, but I have a few questions:

• Is "EIP_191_LEGACY_JSON" the desired name?
• What should be the enum value assigned to it? 192?
• Has any zone already implemented this signMode?
• is allow_alias option in enums allowed in the sdk?

@amaury1729 @tac0turtle