Use bufbuild/protoc-gen-validate to add Protobuf Message validation annotations and auto-generate Validate methods

[odeke-em]

Internally at Orijtech Inc, our very own @kirbyquerby noted that we should be using https://github.com/envoyproxy/protoc-gen-validate to annotate protobuf Message fields for validation, and then have .Validate methods instead of manually writing validators for every struct in code.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

I've looked at this before and I like the idea. I just don't think this particular tools helps us much - it mostly has validations we don't need and doesn't have the ones we do. I propose we do something similar but design it for our use cases.

[tac0turtle]

Closing this, we have looked into it as Aaron mentioned. If we come back to it we can open a new issue

[aaronc]

Now that this tool is maintained by buf and moved to https://github.com/bufbuild/protoc-gen-validate it seems to have evolved a bit and has many more validations which may be useful to use. Thinking we should reopen and consider, especially in light of #11275.

[mfridman]

Hey @aaronc, figured I'd drop here and mention we're working on a v2 version for Protobuf validation, it'll be a runtime library called protovalidate and at its core, it'll use Common Expression Language (CEL).

You can read more about it here: Announcing protoc-gen-validate v1.0 and our plans for v2.0

Having said that, we'll continue to maintain protoc-gen-validate v1 in its current form. We're happy to help or bounce ideas if you like.

[tac0turtle]

we opted to have validation live in the message server, there isnt a need for this anymore