Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmovisor version not displaying correctly #12813

Closed
ValarDragon opened this issue Aug 4, 2022 · 1 comment
Closed

cosmovisor version not displaying correctly #12813

ValarDragon opened this issue Aug 4, 2022 · 1 comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor

Comments

@ValarDragon
Copy link
Contributor

Summary

On many peoples cosmovisor installs, cosmovisor version does not correctly display the cosmovisor version. (It does reliably display the app version, granted this is not annotated well)

Problem Definition

$ cosmovisor version
Cosmovisor Version:  
6:54PM INF Configuration is valid:
Configurable Values:
  DAEMON_HOME: /root/.osmosisd
  DAEMON_NAME: osmosisd
  DAEMON_ALLOW_DOWNLOAD_BINARIES: false
  DAEMON_RESTART_AFTER_UPGRADE: true
  DAEMON_POLL_INTERVAL: 300ms
  UNSAFE_SKIP_BACKUP: true
  DAEMON_PREUPGRADE_MAX_RETRIES: 0
Derived Values:
        Root Dir: /root/.osmosisd/cosmovisor
     Upgrade Dir: /root/.osmosisd/cosmovisor/upgrades
     Genesis Bin: /root/.osmosisd/cosmovisor/genesis/bin/osmosisd
  Monitored File: /root/.osmosisd/data/upgrade-info.json
 module=cosmovisor
6:54PM INF running app args=["version"] module=cosmovisor path=/root/.osmosisd/cosmovisor/upgrades/v11/bin/osmosisd
11.0.0

The cosmovisor version is blank.Not sure if this was installed off of a rtandom SDK branch, release branch, etc. But regardless the cosmovisor version should also be placed there.

While on the topic, ideally the first two lines are:

$ cosmovisor version
Cosmovisor Version:  <real cosmovisor version>
osmosisd App version: 11.0.0
@tac0turtle tac0turtle added the C:Cosmovisor Issues and PR related to Cosmovisor label Aug 4, 2022
@julienrbrt
Copy link
Member

julienrbrt commented Aug 4, 2022

This is already fixed in cosmovisor 1.2.0 (https://github.com/cosmos/cosmos-sdk/blob/main/cosmovisor/CHANGELOG.md).
Your suggestion is as well somewhat already supported:

$ cosmovisor version
cosmovisor version:  1.2.0
0.46.0-2-g1890b8bd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

No branches or pull requests

3 participants