Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e has flaky CLI tests (TestCLIMultisignSortSignatures, TestEditValidatorMoniker and TestCLISignBatch) #13643

Closed
facundomedica opened this issue Oct 25, 2022 · 4 comments

Comments

@facundomedica
Copy link
Member

facundomedica commented Oct 25, 2022

Summary of Bug

I've seen 3 new flaky tests:

    --- FAIL: TestIntegrationTestSuite/TestCLIMultisignSortSignatures (3.37s)
        suite.go:1024: 
            	Error Trace:	/home/ubuntu/actions-runner/_work/cosmos-sdk/cosmos-sdk/tests/e2e/auth/suite.go:1024
            	Error:      	Not equal: 
            	            	expected: math.Int{i:(*big.Int)(0xc0043df100)}
            	            	actual  : math.Int{i:(*big.Int)(0xc002243280)}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -3,5 +3,3 @@
            	            	   neg: (bool) false,
            	            	-  abs: (big.nat) (len=1) {
            	            	-   (big.Word) 10
            	            	-  }
            	            	+  abs: (big.nat) <nil>
            	            	  })
            	Test:       	TestIntegrationTestSuite/TestCLIMultisignSortSignatures

and

--- FAIL: TestIntegrationTestSuite (109.64s)
    suite.go:42: setting up integration test suite
    network.go:289: acquiring test network lock
    network.go:299: preparing test network with chain-id "chain-dzqeIU"
    network.go:568: starting test network...
    network.go:574: started validator 0
    network.go:574: started validator 1
    network.go:582: started test network at height: 0
    --- FAIL: TestIntegrationTestSuite/TestEditValidatorMoniker (2.19s)
        suite.go:1538: 
            	Error Trace:	/home/ubuntu/actions-runner/_work/cosmos-sdk/cosmos-sdk/tests/e2e/staking/client/testutil/suite.go:1538
            	Error:      	Not equal: 
            	            	expected: "node0"
            	            	actual  : "testing"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-node0
            	            	+testing
            	Test:       	TestIntegrationTestSuite/TestEditValidatorMoniker

and

    --- FAIL: TestIntegrationTestSuite/TestCLISignBatch (4.69s)
        suite.go:320: 
            	Error Trace:	/home/runner/work/cosmos-sdk/cosmos-sdk/tests/e2e/auth/suite.go:320
            	Error:      	Not equal: 
            	            	expected: 0x9
            	            	actual  : 0x8
            	Test:       	TestIntegrationTestSuite/TestCLISignBatch
@facundomedica facundomedica changed the title e2e has flaky CLI tests e2e has flaky CLI tests (TestCLIMultisignSortSignatures and TestEditValidatorMoniker) Oct 25, 2022
@rksingh2001
Copy link

Can I pick up this issue?

@julienrbrt
Copy link
Member

Can I pick up this issue?

That'd be awesome :)

@julienrbrt julienrbrt changed the title e2e has flaky CLI tests (TestCLIMultisignSortSignatures and TestEditValidatorMoniker) e2e has flaky CLI tests (TestCLIMultisignSortSignatures, TestEditValidatorMoniker and TestCLISignBatch) Nov 4, 2022
@julienrbrt
Copy link
Member

julienrbrt commented Nov 16, 2022

Hey, @rksingh2001 do you mind if I take a quick stab at this instead?
It started to annoy me too much (after needing to retry this 5 times: https://github.com/cosmos/cosmos-sdk/actions/runs/3478464259)

@julienrbrt julienrbrt self-assigned this Nov 16, 2022
@julienrbrt julienrbrt moved this to 📝 Todo in Cosmos-SDK Nov 16, 2022
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Nov 16, 2022
@julienrbrt julienrbrt mentioned this issue Nov 18, 2022
19 tasks
@julienrbrt julienrbrt moved this from 💪 In Progress to 📝 Todo in Cosmos-SDK Dec 28, 2022
@julienrbrt
Copy link
Member

Tracked by #9010

@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Jan 14, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants