ModuleAccount addresses don't follow ADR-028

[amaury1093]

Summary of Bug

The module account addresses we currently have don't follow ADR-028. I think we simply never bothered to migrate them to ADR-028. Currently, for example for "gov", the module address is:

"gov": cosmos10d07y265gmmuvt4z0w9aw880jnsr700j6zn9kn

However, ADR-028 defines the module account addresses as:

In Basic Address section we defined a module account address as:

address.Hash("module", moduleName)

which gives:

"gov": cosmos1yshfvvjkr5rp6sqykvsy75jqcy25sqj57xrg3ued5cdzdspx7ldq2w8xv0

Version

6ae5641

Steps to Reproduce

func TestModuleAccounts(t *testing.T) {
	// Current module addresses for gov.
	require.Equal(t,
		"cosmos10d07y265gmmuvt4z0w9aw880jnsr700j6zn9kn",
		sdk.AccAddress(crypto.AddressHash([]byte("gov"))).String(),
	)

	// Correct ADR-028 addresses for gov.
	require.Equal(t,
		"cosmos1yshfvvjkr5rp6sqykvsy75jqcy25sqj57xrg3ued5cdzdspx7ldq2w8xv0",
		sdk.AccAddress(address.Hash("module", []byte("gov"))).String(),
	)
}

Also, the ModuleAccount's Validate function is incorrect in validating its address:

cosmos-sdk/x/auth/types/account.go

Lines 239 to 241 in 6ae5641

	if ma.Address != sdk.AccAddress(crypto.AddressHash([]byte(ma.Name))).String() {
	return fmt.Errorf("address %s cannot be derived from the module name '%s'", ma.Address, ma.Name)
	}

It should use the address.Hash("module", moduleName) function.

Proposal

• Change the ModuleAccount validation function to use ADR-028 (i.e. with "module" prefix)
• Do a migration to migrate all addresses

Alternative proposal

We could also change ADR-028 to not use the "module" prefix for module acct addresses. I'm currently not sure of the security implications of this though.

[julienrbrt]

This has been fixed in #14017 where simplifying the ADR have been the solution opted for.