-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid FileDescriptorSet in 0.47 #14713
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of Bug
cosmos.reflection.v1
returns an invalidFileDescriptorSet
that can't be built byprotodesc.NewFiles
.Version
v0.47.0-rc1
Steps to Reproduce
This indicates that the
cosmos.reflection.v1
service we added in v.047 is returning aFileDescriptorSet
with duplicate proto files that can't be turned into a valid instance of https://pkg.go.dev/google.golang.org/protobuf@v1.26.0/reflect/protoregistry#Files. This will cause problems for clients downstream, including but not limited to autocli.Proposed Solution
NewReflectionService
should return an error whenever theFileDescriptorSet
can't be built intoprotoregistry.Files
with helpful error messages and links to documentation. In particular, @testinginprod suggests to return errors in the following cases:gogo.proto
and maybedescriptor.proto
The text was updated successfully, but these errors were encountered: