Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client) add --starting-height flag to simd init #15027

Closed
fragwuerdig opened this issue Feb 14, 2023 · 2 comments · Fixed by #15147
Closed

feat(client) add --starting-height flag to simd init #15027

fragwuerdig opened this issue Feb 14, 2023 · 2 comments · Fixed by #15147
Assignees
Labels

Comments

@fragwuerdig
Copy link
Contributor

Summary

I propose to add a flag to the simd init command, that controls the default starting block height of the output genesis.json

Problem Definition and Proposal

I am frequently spinning local testnets with multiple validators for the blockchain that I am working on. On softforks of the codebase the behavior of these testnets happen to be block height dependent. This comes with the extra burden of creating tooling around modifying the genesis.json after simd init. It feature would not add any "value" to Cosmos SDK. It's just a neat feature. Nice to have. And I am totally happy to implement this on my own. So, please, assign to me.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 14, 2023
@alexanderbez alexanderbez moved this to 📝 Todo in Cosmos-SDK Feb 14, 2023
@alexanderbez
Copy link
Contributor

For sure @fragwuerdig, I think this is a small value add w/o any significant tech overhead. Happy to review a PR!

@tac0turtle tac0turtle added T: UX and removed needs-triage Issue that needs to be triaged labels Feb 14, 2023
@tac0turtle
Copy link
Member

Thanks for opening this issue, we can accommodate this feature. It makes me think if we should add a genesis modification tool to the tools directory since many people have scripts

@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Feb 24, 2023
@tac0turtle tac0turtle moved this to 🥳 Done in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants