Cosmovisor doesn't report its version properly #15360
Assignees
Labels
C:Cosmovisor
Issues and PR related to Cosmovisor
Comments
|
Additionally I am facing the following when running it as |
|
How have you installed cosmovisor? $ go install cosmossdk.io/tools/cosmovisor/cmd/cosmovisor@v1.4.0
$ DAEMON_NAME=simd DAEMON_HOME=~/.simapp DAEMON_DATA_BACK_DIR=~/.simapp/bak cosmovisor version
cosmovisor version: v1.4.0
... |
julienrbrt
added
S:needs more info
For the second point, this is related to gaia not returning a valid JSON and not to Cosmovisor |
I compiled it from source, like described here: https://docs.cosmos.network/main/tooling/cosmovisor#installation.
Just tested it, got the same result as you did. I assume that this is not working only when compiling Cosmovisor from source then. It was totally working before though, I've seen some changes where the version injected into app from ldflags was removed and ReadBuildInfo was used instead, my assumption is that it was broken at that time.
Seems not, I also have it on other nodes, for example this is bitsong (also compiled from source): I am not sure whether these bitsongd/gaiad daemons are writing to stderr or stdout though. |
|
Oh yes, we wanted to make it work with On your second point I am not sure. Does it work for you too with simapp? I know Gaia had some inconsistencies with where some commands were returning (seen a issue recently on their repo about that). |
I guess it makes sense to either deprecate building from binary or make it work properly for binaries built from source, what do you think?
Actually just tested and it seem to work file with simd: On the other hand I just noticed I have some chains that have it working (emoney, simd, jackal) and some have it not working (gaia, bitsong, decentr, sentinel). Wonder if it has something to do with cosmos-sdk version, not sure about it. |
|
I think this is fine, given that it works as intended with I can add a disclaimer in the docs. |
I'm all in, my concern here is that one of the officially recommended ways of installing it is by building from source, so it's nice to have it noted somewhere that the versioning won't work in that case. Adding a disclaimer would work I guess. On the other issue I've mentioned here in comments, should I open another issue on this repository or it isn't something to be fixed and should be rather asked to be fixed by the chain maintainers for the chains it doesn't work properly with? |
19 tasks
|
Right, I've added a disclaimer for that, so it is more clear
Given that it works with (latest) simapp v0.45, (latest) simapp v0.46, (latest) simapp v0.47 and (latest) simapp from main, // set the default command outputs
cmd.SetOut(cmd.OutOrStdout())
cmd.SetErr(cmd.ErrOrStderr()) |
julienrbrt
added
T:Sprint
and removed
S:needs more info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of Bug
When running
cosmovisor versionit displays its version as(devel)instead of a proper version (like 1.4.0, the one I've tested it on).Version
Steps to Reproduce
cosmovisor versionThe text was updated successfully, but these errors were encountered: