-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: use plain files to store snapshots #16066
Labels
Comments
A simpler alternative is just a command that import/export the snapshot in a portable format, basically just bundle the Snapshot message together with the chunk files. |
@tac0turtle didn't you work on a tool to do this? In any case, I think the proposal makes sense. |
there are two caveats though:
|
19 tasks
I'll close this with #16067, it should be good enough for now with these management commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
use plain files to store snapshots for easier out-of-band snapshot syncing
Problem Definition
Right now we store the chunks in files, but snapshot metadata is stored in a kv db, change to plain files will make it easier for external tools to manipulate the snapshots, which will be useful when we use local snapshot restorations and sync the snapshots out-of-band.
Proposal
Just use plain files and directories to store snapshots, without kv db.
os.ReadDir
to iterate the snapshotssnapshot
file to get snapshot metadataThe text was updated successfully, but these errors were encountered: