Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token factory #16137

Closed
faddat opened this issue May 13, 2023 · 5 comments
Closed

Token factory #16137

faddat opened this issue May 13, 2023 · 5 comments
Labels
S:proposed T:feature-request

Comments

@faddat
Copy link
Contributor

faddat commented May 13, 2023

We should put the token factory in sdk 48. When we do that, we should keep the proto domain as osmosis so we don't cause compatibility problems.

PR incoming soonish, suggest that we use Juno's implementation, from the 47 upgrade branch found here:

We should of course review Juno's implementation against Osmosis' and ensure that all desired features are pulled in.

Confo is not interested in having it in wasmd and the need for a standard is fairly urgent.
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 13, 2023
@julienrbrt julienrbrt added S:proposed T:feature-request and removed needs-triage Issue that needs to be triaged labels May 13, 2023
@julienrbrt
Copy link
Member

PR incoming soonish

Maybe you should wait for the team to accept this proposal.

@tac0turtle
Copy link
Member

this should be part of a bank refactor imo, bank was built proir to vms existing in cosmos and now its time to update it. We are working on updating the repo but have limited resources

@Reecepbcups
Copy link
Member

Reecepbcups commented May 13, 2023 •
edited
Loading

The current Tokenfactory depends on cosmwasm. So this would not make sense to PR into now.

Also I'm still working to get test passed for IBC, so it still uses the deprecated x/params. Not ready to PR in...

Would love it natively being built into bank though 🔥

@faddat
Copy link
Contributor Author

faddat commented May 14, 2023

All great points, thanks all

@tac0turtle
Copy link
Member

closing this as we are discussing potential design in bank/v2 issue #17579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S:proposed T:feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@faddat @tac0turtle @julienrbrt @Reecepbcups