Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone mode --with-tendermint false does not work with GRPC and transaction simulation #16277

Closed
p-offtermatt opened this issue May 24, 2023 · 1 comment · Fixed by #18110

Comments

@p-offtermatt
Copy link
Contributor

Summary of Bug

When starting a node with out-of-process Comet, i.e. --with-tendermint false,
it is not possible to simulate transactions e.g. to determine transaction costs with
--gas auto. I am running with out-of-process Comet, and transactions work fine, except when I add --gas auto,
which gives an error:
Error: rpc error: code = Unknown desc = unknown query path: unknown request

I believe the error lies in the startup, where the TxService is registered when starting with in-process Comet

app.RegisterTxService(clientCtx)
, but that functionality is missing when starting standalone Comet here
func startStandAlone(ctx *Context, appCreator types.AppCreator) error {

Version

ec4d9b7

Steps to Reproduce

Run simd with --with-tendermint false and out-of-process Comet, then run a transaction with --gas auto.

@tac0turtle tac0turtle changed the title [Bug]: Standalone mode --with-tendermint false does not work with GRPC and transaction simulation Standalone mode --with-tendermint false does not work with GRPC and transaction simulation May 24, 2023
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Oct 10, 2023
@p-offtermatt
Copy link
Contributor Author

Hey, I played with this today and created this PR #18109 for how I managed to do it on v0.47.

I also have a PR targetting main #18110, but since my testscript isn't up to compatibility with Cosmos SDK main, I didn't have a good way to test this.

With #18109, I can query the grpc server fine for everything I tried. Also, tx simulation worked for me - it fixes the use cases I need, but I assume it doesn't work for everything since I don't give it an actual client context.
Maybe the PRs are still useful as a base-line though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants