[Bug]: simulating a send from a multisig account fails

[JulianToledano]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

When sending a tx with a multisig with --gas=auto it fails with error:
rpc error: code = Unknown desc = rpc error: code = Unknown desc = expected *signing.MultiSignatureData, got, *signing.SingleSignatureData With gas wanted: '18446744073709551615' and gas used: '48980' : unknown request

This is because Signaturev2.Data is always populated as SingleSignatureData

cosmos-sdk/client/tx/factory.go

Lines 408 to 414 in e64f3bc

	sig := signing.SignatureV2{
	PubKey: pk,
	Data: &signing.SingleSignatureData{
	SignMode: f.signMode,
	},
	Sequence: f.Sequence(),
	}

Solution

We could check pubkey type and choose whether to use SingleSignatureData or MultiSignatureData

Cosmos SDK Version

main

How to reproduce?

simd tx bank send $FROM $TO 10000stake --fees 20000stake --gas=auto --chain-id $CHAIN -y

[alexanderbez]

@JulianToledano isn't this a duplicate of #17711?

[JulianToledano]

@JulianToledano isn't this a duplicate of #17711?

It is related to that. #17711 points that the key used to simulate isn't the correct but a random one. With the fix in #18472 the error still persist because the signature is always a SingleSignatureData.

I think we can address this on #18472 but wanted to open this issue to make it more clearer.

[JulianToledano]

@alexanderbez after taking a second look here you are right. I think this is just a duplicate.