Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove address verifier from global sdk.Config #18608

Closed
bizk opened this issue Dec 1, 2023 · 0 comments · Fixed by #18607
Closed

Remove address verifier from global sdk.Config #18608

bizk opened this issue Dec 1, 2023 · 0 comments · Fixed by #18607
Assignees
Labels

Comments

@bizk
Copy link
Contributor

bizk commented Dec 1, 2023

Summary

ref #7448

In the efforts to remove global config, this issue aims to rework the addressverifier config and it usage.
Currently there is an overlaping on using a custom verifier or using the default bech32 check.

Problem Definition

No response

Proposed Feature

Decouple verification and have a clear use case for bech32.

  • If users are using explicit bech32 functions, we run the checks for bech32, not their custom ones, otherwise users could experience weird behaviors.
  • If users want to use custom addresVerifiers they should implement it and the use respective functions
@bizk bizk self-assigned this Dec 1, 2023
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Dec 1, 2023
@educlerici-zondax educlerici-zondax moved this from 👀 To Do to ✍ In Progress in Cosmos-SDK Dec 1, 2023
@educlerici-zondax educlerici-zondax added the S:zondax Squad: Zondax label Dec 1, 2023
@github-project-automation github-project-automation bot moved this from ✍ In Progress to 🥳 Done in Cosmos-SDK Feb 2, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants