Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify all genesis return errors #19713

Closed
julienrbrt opened this issue Mar 11, 2024 · 1 comment · Fixed by #19740
Closed

Verify all genesis return errors #19713

julienrbrt opened this issue Mar 11, 2024 · 1 comment · Fixed by #19740
Assignees
@chixiaowen
Labels
good first issue

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Mar 11, 2024 •
edited
Loading

After the change of the genesis API in #19627, we should now ensure we do not panic in InitGenesis and ExportGenesis of our module code but instead return the errors.

  • Go to each x/** folder
  • Verify InitGenesis and ExportGenesis module code and keeper code do not panic
  • Update panic to errors
  • Add CHANGELOG in x/**/CHANGELOG.md when relevant.
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Mar 11, 2024
@chixiaowen
Copy link
Contributor

@julienrbrt , hello, let me do it

@julienrbrt julienrbrt mentioned this issue Mar 12, 2024
Merged
12 tasks
@chixiaowen chixiaowen mentioned this issue Mar 13, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Mar 13, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chixiaowen chixiaowen

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(x/**)!: genesis return errors chixiaowen/cosmos-sdk
2 participants
@chixiaowen @julienrbrt