Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Panic when overriding existing msg account #20673

Closed
1 task done
raynaudoe opened this issue Jun 14, 2024 · 3 comments
Closed
1 task done

[Bug]: Panic when overriding existing msg account #20673

raynaudoe opened this issue Jun 14, 2024 · 3 comments
Labels

Comments

@raynaudoe
Copy link
Contributor

raynaudoe commented Jun 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Panic when trying to replace an existing msig account with another one with the same name.

Doesn't panic on v0.50.7 but on main (possible regression)

Likely to be related to #20382

Cosmos SDK Version

main

How to reproduce?

./build/simd keys add alice --keyring-backend test 
./build/simd keys add bob --keyring-backend test

./build/simd keys add ms1 --multisig alice,bob --multisig-threshold 2 --keyring-backend test
./build/simd keys add ms1 --multisig alice,bob --multisig-threshold 1 --keyring-backend test

Error

main.main()
        cosmossdk.io/simapp/simd/main.go:15 +0x3c
panic: amino binary marshal marshaling error for {TypeUrl:/cosmos.crypto.secp256k1.PubKey Value:[10 33 3 79 75 188 230 163 79 248 222 112 164 132 202 3 52 54 175 40 169 79 111 223 173 151 98 170 104 130 4 212 96 159 171] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0 cachedValue:0x14000b00228 compat:<nil>}, this is likely because amino is being used directly (instead of codec.LegacyAmino which is preferred) or UnpackInterfacesMessage is not defined for some type which contains a protobuf Any either directly or via one of its members. To see a stacktrace of where the error is coming from, set the var Debug = true in codec/types/compat.go
@tac0turtle
Copy link
Member

i believe @facundomedica has an open pr for this?

@tac0turtle
Copy link
Member

@raynaudoe we just merged facus pr, can you retry the issue

@tac0turtle tac0turtle changed the title [Bug]: Panic when overriding existing msig account [Bug]: Panic when overriding existing msg account Jun 18, 2024
@facundomedica
Copy link
Member

Closing in favor of #20382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants