Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: various improvements #2089

Closed
ebuchman opened this issue Aug 20, 2018 · 3 comments
Closed

crypto: various improvements #2089

ebuchman opened this issue Aug 20, 2018 · 3 comments
Labels

Comments

@ebuchman
Copy link
Member

The package has gotten a bit messy and is in need of cleanup. Consider the following.

  • clarify what function changed in the bcrypt fork
  • fork the correct go-bip39 into here and remove the current bip39 wrapper
  • reduce dependencies on tendermint/crypto if/where possible
  • mintkey.go should be its own pkg with exposed funcs (doesn't need to be covered by semver tho)
  • add support for bip39 passphrases
  • add support for generating your own entropy
  • keybase needs a cleanup (interface seems bloated)
@ValarDragon
Copy link
Contributor

ValarDragon commented Aug 20, 2018

Why are we forking the bip 39 codebase into the sdk? I'm not opposed to forking but wouldn't this be better as a separate repo so we can get upstream updates

@ebuchman
Copy link
Member Author

Why are we forking the bip 39 codebase into the sdk? I'm not opposed to forking but wouldn't this be better as a separate repo so we can get upstream updates

In this case the repo is small enough that we shouldn't be expecting to pull in anything from upstream.

@jackzampolin
Copy link
Member

This has been substantially completed. Going to close this issue. Please reopen individual issues for remaining action items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants