-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/v2 Indexer Integration #21527
Labels
Comments
julienrbrt
added
C:schema
C:server/v2 stf
and removed
needs-triage
Issue that needs to be triaged
labels
Sep 3, 2024
12 tasks
12 tasks
I don't think this should have been closed. That PR as far as I know was just one part of the implementation. |
12 tasks
12 tasks
this closable? cc @facundomedica |
Not yet, needs you be double cheeked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To support indexing in
server/v2
we need to setup locations forappdata.Listener
callbacks to be invoked. Two possible locations for this are:Integration into
cometbft/streaming.go
might be easier but IMHO is less ideal and less performant. The ideal integration spot IMHO would be directly instf
and a draft PR was created here: #21273.Ideally, #21312 should be completed first and then a first class integration of
appdata.Listener
can be added directly tostf
.The text was updated successfully, but these errors were encountered: