-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Add loose/bonded token supply invariants back to simulation #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, I expected this to pass after #2163 was merged. Should be investigated. |
23 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2162 +/- ##
========================================
Coverage 61.52% 61.52%
========================================
Files 122 122
Lines 7486 7486
========================================
Hits 4606 4606
Misses 2561 2561
Partials 319 319 |
cwgoes
changed the title
WIP: Simulation++
R4R: Add loose/bonded token supply invariants back to simulation
Sep 27, 2018
alexanderbez
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK -- although the returned errors are extremely long and hard to read. Might help breaking them onto multiple lines 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Standard checklist
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: