Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add loose/bonded token supply invariants back to simulation #2162

Merged
merged 6 commits into from
Sep 27, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Aug 27, 2018

Features

Standard checklist

  • Linked to github-issue with discussion and accepted design
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 1, 2018

Hmm, I expected this to pass after #2163 was merged. Should be investigated.

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #2162 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2162   +/-   ##
========================================
  Coverage    61.52%   61.52%           
========================================
  Files          122      122           
  Lines         7486     7486           
========================================
  Hits          4606     4606           
  Misses        2561     2561           
  Partials       319      319

@cwgoes cwgoes changed the title WIP: Simulation++ R4R: Add loose/bonded token supply invariants back to simulation Sep 27, 2018
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK -- although the returned errors are extremely long and hard to read. Might help breaking them onto multiple lines 👍

@cwgoes cwgoes merged commit f7cb351 into develop Sep 27, 2018
@cwgoes cwgoes deleted the cwgoes/simulation++ branch September 27, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants