Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: server/v2 server components are not configured by command line flags #22237

Closed
1 task done
kocubinski opened this issue Oct 11, 2024 · 2 comments · Fixed by #22241
Closed
1 task done

[Bug]: server/v2 server components are not configured by command line flags #22237

kocubinski opened this issue Oct 11, 2024 · 2 comments · Fixed by #22241
Assignees
Labels

Comments

@kocubinski
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

❯ simdv2 start --log_format json
simd root command persistent pre-run []
{"level":"warn","error":"register service: unable to find protov2 service descriptor: please make sure protov2 API counterparty is imported: cosmos.accounts.v1.Msg","time":"2024-10-11T11:08:17-05:00","message":"error registering services"}
{"level":"warn","error":"register service: unable to find protov2 service descriptor: please make sure protov2 API counterparty is imported: cosmos.gov.v1beta1.Query","time":"2024-10-11T11:08:17-05:00","message":"error registering services"}
{"level":"warn","error":"unable to make a appmodulev2.HandlerFunc from gRPC handler (cosmos.reflection.v1.ReflectionService, FileDescriptors): no proto message found for cosmos.reflection.v1.FileDescriptorsRequest","time":"2024-10-11T11:08:17-05:00","message":"error registering services"}
11:08AM INF starting servers...
{"level":"info","module":"comet","module":"p2p","ID":"8f9f085a9f13bf459bcf215d0a8e1ce87662affa","file":"/Users/mattk/.simappv2/config/node_key.json","time":"2024-10-11T11:08:17-05:00","message":"P2P Node ID"}

I expected all output to be JSON formatted, but the server components do not respect this input.

Cosmos SDK Version

main

How to reproduce?

see above command.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Oct 11, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Oct 11, 2024

Oh, we don't have the flags at the server creation :(

We basically have two logger, one created for the app (with all the flags):

log, err := NewLogger(v, cmd.OutOrStdout())

One created for the servers:

Not too sure how to fix this :/

@julienrbrt
Copy link
Member

I think i know actually, lmc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants