Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: store/v2: support archive node migration #22530

Closed
kocubinski opened this issue Nov 14, 2024 · 8 comments
Closed

[Feature]: store/v2: support archive node migration #22530

kocubinski opened this issue Nov 14, 2024 · 8 comments
Assignees
Labels

Comments

@kocubinski
Copy link
Member

Summary

store/v2 migrations support migrating from a snapshot, which is ideal for a high throughput validator, but this does not account for migrating (or after migration, retrieving) historical state.

Problem Definition

Today, after migrating to store/v2, historical state present prior to the snapshot used for migration is no longer accessible to the state machine or query handlers.

Proposed Feature

  1. A migration path for all store/v1 SC keys into store/v2 SS
  2. In lieu of (1), store/v2 should fall back to the store/v1 SC database on version miss.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Nov 14, 2024
@kocubinski kocubinski added C:Store C:server/v2 Issues related to server/v2 labels Nov 14, 2024
@tac0turtle
Copy link
Member

we should be able to offer a simple command line to transfer the data for node operators that would like to

@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Dec 5, 2024
@kocubinski
Copy link
Member Author

Since SS was removed from store/v2 in #22683 this is no longer relevant.

@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Dec 11, 2024
@tac0turtle
Copy link
Member

we should still have migration for iavlv2 no?

@kocubinski
Copy link
Member Author

iavl v2 could use some attention for migrations. presently the only supported migration is iavl v0 -> iavl v2, and that is latest state only. should that be a feature of iavl v2 or store/v2 though?

@tac0turtle
Copy link
Member

i was thinking a cmd that uses that the user runs and does gets and sets, it will be slow but its the best we can do

@kocubinski
Copy link
Member Author

so migrate between 2 arbitrary SC stores?

@kocubinski
Copy link
Member Author

for historical state recovery, this is not trivial. I wrote a tool to recover the full state log from an iavl v0 db on TB scale and it takes on the order of 12-48 hours to run.

re opening for now, let's discuss synchronously on tomorrow's SDK call?

@kocubinski kocubinski reopened this Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK Dec 11, 2024
@tac0turtle
Copy link
Member

closing this after the previous discussion

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

No branches or pull requests

3 participants